Skip to content

Run post_install when needed #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 20, 2020
Merged

Run post_install when needed #893

merged 10 commits into from
Aug 20, 2020

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 13, 2020

Run post_install.sh script on trusted platforms

Also:

  • refactored executils.Command
  • added IsTrusted flag in PlatformReleases

@cmaglie cmaglie self-assigned this Aug 13, 2020
@cmaglie cmaglie force-pushed the run_platform_postinstall branch from 13d35d1 to 382581a Compare August 13, 2020 15:42
@matthijskooijman
Copy link
Collaborator

Does it really add anything to add an isTrusted flag here? AFAICS, an "untrusted" platform can still provide custom compiler binaries and compiler commands in platform.txt, so this trusted flag would only prevent running untrusted code at platform install time, as soon as you actually use the platform to compile a sketch, untrusted code will be ran in any case?

@cmaglie
Copy link
Member Author

cmaglie commented Aug 13, 2020

that's right, probably we should run post-install also for unsigned/3rd party.

@luigigubello WDYT?

@cmaglie
Copy link
Member Author

cmaglie commented Aug 13, 2020

FWIW I've ported this as-is from the Arduino IDE, so in case it should be changed also in the Arduino IDE.

@cmaglie cmaglie force-pushed the run_platform_postinstall branch from bf14fd7 to 382581a Compare August 14, 2020 12:40
rsora
rsora reviewed Aug 19, 2020
View reviewed changes
cli/core/upgrade.go
Instance: inst,
PlatformPackage: platformRef.PackageName,
Architecture: platformRef.Architecture,
SkipPostInstall: detectSkipPostInstallValue(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silvanocerza could you please check if the --run-post-install and --skip-post-install flags need to be ported also in arduino-cli update and upgrade commands?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll check it out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at it and think it might be necessary to port them on the upgrade command, it don't think it should be necessary for update since it just downloads the index files.

@cmaglie cmaglie force-pushed the run_platform_postinstall branch from 164ebec to 37bcb72 Compare August 20, 2020 09:36
@cmaglie cmaglie force-pushed the run_platform_postinstall branch from 37bcb72 to 522135b Compare August 20, 2020 10:04
@cmaglie cmaglie merged commit 034dd0f into arduino:master Aug 20, 2020
@cmaglie cmaglie deleted the run_platform_postinstall branch August 20, 2020 11:19
@cmaglie cmaglie mentioned this pull request Aug 20, 2020
Merged
@per1234 per1234 mentioned this pull request Sep 10, 2020
Merged
4 tasks
@per1234 per1234 mentioned this pull request Jan 21, 2022
Closed
@per1234 per1234 mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facchinm facchinm facchinm approved these changes

+2 more reviewers

@silvanocerza silvanocerza silvanocerza left review comments

@rsora rsora rsora left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cmaglie cmaglie

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cmaglie @matthijskooijman @silvanocerza @facchinm @rsora